-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RNMobile] Use text-align to center multiline text in inserter #37185
Merged
mchowning
merged 2 commits into
trunk
from
rnmobile/fix/align-multiline-block-names-in-inserter
Dec 10, 2021
Merged
[RNMobile] Use text-align to center multiline text in inserter #37185
mchowning
merged 2 commits into
trunk
from
rnmobile/fix/align-multiline-block-names-in-inserter
Dec 10, 2021
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
2 tasks
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
fluiddot
approved these changes
Dec 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎊 !
Tested on Simulator - iPhone 12 Pro Max (iOS 15.0) and Samsung Galaxy S20 FE 5G (Android 10).
mchowning
force-pushed
the
rnmobile/fix/align-multiline-block-names-in-inserter
branch
from
December 10, 2021 16:52
8fffe38
to
ee18051
Compare
mchowning
deleted the
rnmobile/fix/align-multiline-block-names-in-inserter
branch
December 10, 2021 18:00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gutenberg-Mobile PR: wordpress-mobile/gutenberg-mobile#4343
Description
This PR fixes #34748, which noted that block titles spanning multiple lines are not centrally aligned in the inserter.
How has this been tested?
Screenshots
Types of changes
Bug fix
Checklist:
*.native.js
files for terms that need renaming or removal).